]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drivers/net/wireless: introduce missing kfree
authorJulia Lawall <julia@diku.dk>
Sat, 1 Aug 2009 08:55:53 +0000 (10:55 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 3 Aug 2009 20:31:23 +0000 (16:31 -0400)
commit9f9857bb5e147b977b9878c46e3dd87c9e8caf50
tree614826c5d1f65189a29126771e6a903d5c4ea8c5
parentc37457e69ffd7d3c94cbfcc1c39be9a45dd7ad21
drivers/net/wireless: introduce missing kfree

Error handling code following a kzalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwmc3200wifi/commands.c