]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
drm/i915/icl: Fix MG PLL setup when refclk is 38.4MHz
authorImre Deak <imre.deak@intel.com>
Fri, 15 Jun 2018 14:39:10 +0000 (17:39 +0300)
committerImre Deak <imre.deak@intel.com>
Thu, 21 Jun 2018 16:01:40 +0000 (19:01 +0300)
commit9fc59bae0f4a8ec3676a9245abed7721b4d3d8c9
tree094875e762542cc958191e4bebe7be74344bf2e8
parent8a29c778fa1a50a25a3e66cf9589888758858d24
drm/i915/icl: Fix MG PLL setup when refclk is 38.4MHz

Atm we're zeroing out fields in MG_PLL_BIAS and MG_PLL_TDC_COLDST_BIAS
if refclk is 38.4MHz, whereas the spec tells us to preserve them.
Although the calculated values mostly match the register defaults even
for the 38.4MHz case, there are some differences wrt. what BIOS
programs (I noticed at least differences in the MG_PLL_BIAS/IREFTRIM and
MG_PLL_BIAS/BIASCAL_EN fields). In the lack of further info on how to
program these fields, just do what the spec says and preserve the BIOS
state.

v2:
- Preserve the BIOS programmed reg fields instead of programming them.

Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: James Ausmus <james.ausmus@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: James Ausmus <james.ausmus@intel.com> (v1)
Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180615143911.31082-1-imre.deak@intel.com
drivers/gpu/drm/i915/intel_dpll_mgr.c
drivers/gpu/drm/i915/intel_dpll_mgr.h