]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
platform/x86: fix kconfig dependency warning for FUJITSU_LAPTOP
authorNecip Fazil Yildiran <fazilyildiran@gmail.com>
Thu, 17 Sep 2020 16:16:53 +0000 (19:16 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 9 Nov 2020 13:48:22 +0000 (14:48 +0100)
commit9fc6509cd67129674c10bb3815ab1be5baf62a44
treebc6b3ad5173e12edb55bc59170719ad30e171c7c
parent50aaa39cfacc518186656f5c92a2c07cedd047ae
platform/x86: fix kconfig dependency warning for FUJITSU_LAPTOP

BugLink: https://bugs.launchpad.net/bugs/1902110
[ Upstream commit afdd1ebb72051e8b6b83c4d7dc542a9be0e1352d ]

When FUJITSU_LAPTOP is enabled and NEW_LEDS is disabled, it results in the
following Kbuild warning:

WARNING: unmet direct dependencies detected for LEDS_CLASS
  Depends on [n]: NEW_LEDS [=n]
  Selected by [y]:
  - FUJITSU_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] || ACPI_VIDEO [=n]=n)

The reason is that FUJITSU_LAPTOP selects LEDS_CLASS without depending on
or selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

Reported-by: Hans de Goede <hdegoede@redhat.com>
Fixes: d89bcc83e709 ("platform/x86: fujitsu-laptop: select LEDS_CLASS")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Ian May <ian.may@canonical.com>
drivers/platform/x86/Kconfig