]> git.proxmox.com Git - mirror_qemu.git/commit
chardev: don't exit() straight away on C-a x
authorAlex Bennée <alex.bennee@linaro.org>
Tue, 26 Oct 2021 10:22:24 +0000 (11:22 +0100)
committerAlex Bennée <alex.bennee@linaro.org>
Thu, 4 Nov 2021 10:32:01 +0000 (10:32 +0000)
commita00e37a4be88a043fea3e8be3ee3a85f6c4939cf
treef09dfffdd4e02dd191d2d300ab07b527ca243711
parentb8312e04c8116b7787c54eb6c3cfee712b74f2f3
chardev: don't exit() straight away on C-a x

While there are a number of uses in the code-base of the exit(0)
pattern it gets in the way of clean exit which can do all of it's
house-keeping. In particular it was reported that you can crash
plugins this way because TCG can still be running on other threads
when the atexit callback is called.

Use qmp_quit() instead which takes care of some housekeeping before
triggering the shutdown.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reported-by: Lukas Jünger <lukas.junger@greensocs.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20211026102234.3961636-19-alex.bennee@linaro.org>
chardev/char-mux.c
stubs/meson.build
stubs/qmp-quit.c [new file with mode: 0644]