]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
nvram: Fix write beyond end condition; prove to gcc copy is safe
authorH. Peter Anvin <hpa@zytor.com>
Fri, 11 Dec 2009 23:48:23 +0000 (15:48 -0800)
committerH. Peter Anvin <hpa@zytor.com>
Fri, 11 Dec 2009 23:48:23 +0000 (15:48 -0800)
commita01c7800420d2c294ca403988488a635d4087a6d
treea0a5eeb436a297dffead2dfbccbb0ad3013aa7d1
parentb925585039cf39275c2e0e57512e5df27fa73aad
nvram: Fix write beyond end condition; prove to gcc copy is safe

In nvram_write, first of all, correctly handle the case where the file
pointer is already beyond the end; we should return EOF in that case.

Second, make the logic a bit more explicit so that gcc can statically
prove that the copy_from_user() is safe.  Once the condition of the
beyond-end filepointer is eliminated, the copy is safe but gcc can't
prove it, causing build failures for i386 allyesconfig.

Third, eliminate the entirely superfluous variable "len", and just use
the passed-in variable "count" instead.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <tip-*@git.kernel.org>
drivers/char/nvram.c