]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
usb: core: Copy parameter string correctly and remove superfluous null check
authorKai-Heng Feng <kai.heng.feng@canonical.com>
Fri, 23 Mar 2018 19:26:35 +0000 (03:26 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Mar 2018 10:50:44 +0000 (12:50 +0200)
commita030501499b032bd218e1d01c07677bab6a0d53f
tree9924faca7e061bc17c1f7257606a8f307bd9b32d
parent73c6d3b284cf7b31c03fdaa2476f48f8da0932f8
usb: core: Copy parameter string correctly and remove superfluous null check

strsep() slices string, so the string gets copied by
param_set_copystring() at the end of quirks_param_set() is not the
original value.
Fix that by calling param_set_copystring() earlier.

The null check for val is unnecessary, the caller of quirks_param_set()
does not pass null string.
Remove the superfluous null check. This is found by Smatch.

Fixes: 027bd6cafd9a ("usb: core: Add "quirks" parameter for usbcore")
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/quirks.c