]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
block: remove inaccurate requeue check
authorJens Axboe <axboe@kernel.dk>
Wed, 20 Oct 2021 14:21:40 +0000 (08:21 -0600)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Thu, 13 Jan 2022 17:42:11 +0000 (18:42 +0100)
commita05bc1ce0a1e43da2a08b96e8de3a44b93459ea3
treee12caf494edae0d28df6e4aab61518335c5c059f
parentac40de37637e29d92edac31722d163d9a760f9e7
block: remove inaccurate requeue check

BugLink: https://bugs.launchpad.net/bugs/1953387
[ Upstream commit 037057a5a979c7eeb2ee5d12cf4c24b805192c75 ]

This check is meant to catch cases where a requeue is attempted on a
request that is still inserted. It's never really been useful to catch any
misuse, and now it's actively wrong. Outside of that, this should not be a
BUG_ON() to begin with.

Remove the check as it's now causing active harm, as requeue off the plug
path will trigger it even though the request state is just fine.

Reported-by: Yi Zhang <yi.zhang@redhat.com>
Link: https://lore.kernel.org/linux-block/CAHj4cs80zAUc2grnCZ015-2Rvd-=gXRfB_dFKy=RTm+wRo09HQ@mail.gmail.com/
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
block/blk-mq.c