]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
batman-adv: Use kref_get for batadv_gw_select
authorSven Eckelmann <sven@narfation.org>
Sat, 5 Mar 2016 15:09:22 +0000 (16:09 +0100)
committerAntonio Quartulli <a@unstable.cc>
Tue, 10 May 2016 10:28:29 +0000 (18:28 +0800)
commita08d497d6718d579e496a801115aecc1c4fbb770
tree072f27ad47d2579fa3079dab370e1fd98b47f525
parent0de32ceee156787429035c974316f4e5098cf722
batman-adv: Use kref_get for batadv_gw_select

batadv_gw_select requires that the caller already has a valid reference for
new_gw_node. It is therefore not possible that it has an reference counter
of 0 and was still given to this function

The kref_get function instead WARNs (with debug information) when the
reference counter would still be 0. This makes a bug in batman-adv better
visible because kref_get_unless_zero would have ignored this problem.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
net/batman-adv/gateway_client.c