]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ASoC: rt5677: Fix initialization of rt5677_of_match.data
authorMatthias Kaehlcke <mka@chromium.org>
Tue, 7 Aug 2018 17:19:40 +0000 (10:19 -0700)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:46:42 +0000 (19:46 -0600)
commita0cb584a3425f5f23f296d2033ce10c4e92fb061
tree254c8af845ca35d8fe17d1f43442156ed8632946
parent0f363429d2e6d716efc36a0042c02ecc610b68ad
ASoC: rt5677: Fix initialization of rt5677_of_match.data

BugLink: https://bugs.launchpad.net/bugs/1835972
[ Upstream commit f861e3e28a3016a2064d9f600eaa92a530b732b4 ]

The driver expects to find the device id in rt5677_of_match.data, however
it is currently assigned to rt5677_of_match.type. Fix this.

The problem was found with the help of clang:
  sound/soc/codecs/rt5677.c:5010:36: warning: expression which evaluates to
  zero treated as a null pointer constant of type 'const void *'
  [-Wnon-literal-null-conversion]
    { .compatible = "realtek,rt5677", RT5677 },
                                      ^~~~~~

Fixes: ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data in the module sources")
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
sound/soc/codecs/rt5677.c