]> git.proxmox.com Git - mirror_qemu.git/commit
sheepdog: Mark sd_snapshot_delete() lossage FIXME
authorMarkus Armbruster <armbru@redhat.com>
Mon, 6 Mar 2017 19:00:38 +0000 (20:00 +0100)
committerKevin Wolf <kwolf@redhat.com>
Tue, 7 Mar 2017 13:53:28 +0000 (14:53 +0100)
commita0dc0e2bfe543404c07258b2a2c4f9d53c0430b1
tree01d5efe0ee24f964ae050fa07e4b0afa17ecd8b6
parent48d7c4af06393b974b0a515ac9d1cc7346dbae23
sheepdog: Mark sd_snapshot_delete() lossage FIXME

sd_snapshot_delete() should delete the snapshot whose ID matches
@snapshot_id and whose name matches @name.  But that's not what it
does.  If @snapshot_id is a valid ID, it deletes the snapshot with
that ID, else it deletes the snapshot with that name.  It doesn't use
@name at all.  Add suitable FIXME comments, so someone who actually
knows Sheepdog can fix it.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/sheepdog.c