]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
serial: sh-sci: Don't check for mctrl_gpio_to_gpiod() returning error
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 14 Aug 2019 09:29:24 +0000 (11:29 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Sep 2019 10:43:54 +0000 (12:43 +0200)
commita16c4c5a9cb6368a08c457b6b2dc0be25958dfc0
treee2ca7f57ca957a6b87cbd4b06c5b2c9f63a9e930
parent18a4c404d2b4de47da519955ddda0b153c03f12d
serial: sh-sci: Don't check for mctrl_gpio_to_gpiod() returning error

Since commit 1d267ea6539f2663 ("serial: mctrl-gpio: simplify init
routine"), mctrl_gpio_init() returns failure if the assignment to any
member of the gpio array results in an error pointer.
Since commit c359522194593815 ("serial: mctrl_gpio: Avoid probe failures
in case of missing gpiolib"), mctrl_gpio_to_gpiod() returns NULL in the
!CONFIG_GPIOLIB case.
Hence there is no longer a need to check for mctrl_gpio_to_gpiod()
returning an error value.  A simple NULL check is sufficient.

This follows the spirit of commit 445df7ff3fd1a0a9 ("serial: mctrl-gpio:
drop usages of IS_ERR_OR_NULL") in the mctrl-gpio core.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20190814092924.13857-4-geert+renesas@glider.be
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c