]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tue, 10 Apr 2018 05:38:52 +0000 (14:38 +0900)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 5 Sep 2018 08:30:45 +0000 (10:30 +0200)
commita1b709b51834b28546eaa2d72a1a676b06f72382
tree1af7457de350664a34b6877c20dd7e24c2710d36
parent49658ba74d76bdd3a8d710cbb695db486fb0d1ec
usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc

BugLink: http://bugs.launchpad.net/bugs/1790188
commit 003bc1dee216b1fb8e02040a95672bea0f1fe797 upstream.

This patch fixes an issue that this driver cannot call phy_init()
if a gadget driver is alreadly loaded because usb_add_gadget_udc()
might call renesas_usb3_start() via .udc_start.
This patch also revises the typo (s/an optional/optional/).

Fixes: 279d4bc64060 ("usb: gadget: udc: renesas_usb3: add support for generic phy")
Cc: <stable@vger.kernel.org> # v4.15+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/gadget/udc/renesas_usb3.c