]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
USB: serial: ch341: fix character loss at high transfer rates
authorWilly Tarreau <w@1wt.eu>
Sat, 24 Jul 2021 15:27:39 +0000 (17:27 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 20 Sep 2021 13:42:56 +0000 (15:42 +0200)
commita21760c528d6aea7dabdaa54bcdcd4938200f3ac
tree6ecb55230dd8f4ffbf98c7b1cc4fd15d74f98721
parenteb80a21764b5533a0f25cbf588867d6165fdaf88
USB: serial: ch341: fix character loss at high transfer rates

BugLink: https://bugs.launchpad.net/bugs/1942123
commit 3c18e9baee0ef97510dcda78c82285f52626764b upstream.

The chip supports high transfer rates, but with the small default buffers
(64 bytes read), some entire blocks are regularly lost. This typically
happens at 1.5 Mbps (which is the default speed on Rockchip devices) when
used as a console to access U-Boot where the output of the "help" command
misses many lines and where "printenv" mangles the environment.

The FTDI driver doesn't suffer at all from this. One difference is that
it uses 512 bytes rx buffers and 256 bytes tx buffers. Adopting these
values completely resolved the issue, even the output of "dmesg" is
reliable. I preferred to leave the Tx value unchanged as it is not
involved in this issue, while a change could increase the risk of
triggering the same issue with other devices having too small buffers.

I verified that it backports well (and works) at least to 5.4. It's of
low importance enough to be dropped where it doesn't trivially apply
anymore.

Cc: stable@vger.kernel.org
Signed-off-by: Willy Tarreau <w@1wt.eu>
Link: https://lore.kernel.org/r/20210724152739.18726-1-w@1wt.eu
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/serial/ch341.c