]> git.proxmox.com Git - mirror_frr.git/commit
tests: Convert over to using converged to test for ospf being converged
authorDonald Sharp <sharpd@nvidia.com>
Wed, 13 Oct 2021 16:46:22 +0000 (12:46 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Wed, 13 Oct 2021 16:46:22 +0000 (12:46 -0400)
commita22d51e21eb23d423e59d9c8f1973200283e6f69
treea48e11c28585386ee8cffa92d4dbfc26a821d882
parent3766c36a209de3e33df05f71642664921d9cc6c5
tests: Convert over to using converged to test for ospf being converged

OSPF when it is deciding on whom it should elect for DR and backup
has a process that prioritizes network stabilty over the exact
same results of who is the DR / Backups.

Essentially if we have r1 ----- r2

Let's say r1 has a higher priority, but r2 comes up first, starts
sending hello packets and then decides that it is the DR.  At some
point in time in the future, r1 comes up and then connects to r2
at that point it sees that r2 has elected itself DR and it keeps
it that way.

This is by design of the system.  With our tight ospf timers as
well as high load being experienced on our test systems.  There
exists a bunch of ospf tests that we cannot guarantee that a
consistent DR will be elected for the test.  As such let's not
even pretend that we care a bunch and just look for `Full`.
If we care about `ordering` we need to spend more time getting
the tests to actually start routers, ensure that htey are up and
running in the right order so that priority can take place.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
28 files changed:
tests/topotests/bgp_features/r1/ospf_neighbor.json
tests/topotests/bgp_features/r2/ospf_neighbor.json
tests/topotests/bgp_features/r3/ospf_neighbor.json
tests/topotests/ldp_oc_acl_topo1/r1/show_ip_ospf_neighbor.json
tests/topotests/ldp_oc_acl_topo1/r2/show_ip_ospf_neighbor.json
tests/topotests/ldp_oc_acl_topo1/r3/show_ip_ospf_neighbor.json
tests/topotests/ldp_oc_acl_topo1/r4/show_ip_ospf_neighbor.json
tests/topotests/ldp_oc_topo1/r1/show_ip_ospf_neighbor.json
tests/topotests/ldp_oc_topo1/r2/show_ip_ospf_neighbor.json
tests/topotests/ldp_oc_topo1/r3/show_ip_ospf_neighbor.json
tests/topotests/ldp_oc_topo1/r4/show_ip_ospf_neighbor.json
tests/topotests/ldp_sync_ospf_topo1/r1/show_ip_ospf_neighbor.json
tests/topotests/ldp_sync_ospf_topo1/r2/show_ip_ospf_neighbor.json
tests/topotests/ldp_sync_ospf_topo1/r3/show_ip_ospf_neighbor.json
tests/topotests/ldp_vpls_topo1/r1/show_ip_ospf_neighbor.json
tests/topotests/ldp_vpls_topo1/r2/show_ip_ospf_neighbor.json
tests/topotests/ldp_vpls_topo1/r3/show_ip_ospf_neighbor.json
tests/topotests/ospf_gr_topo1/rt1/show_ip_ospf_neighbor.json
tests/topotests/ospf_gr_topo1/rt2/show_ip_ospf_neighbor.json
tests/topotests/ospf_gr_topo1/rt3/show_ip_ospf_neighbor.json
tests/topotests/ospf_gr_topo1/rt4/show_ip_ospf_neighbor.json
tests/topotests/ospf_gr_topo1/rt5/show_ip_ospf_neighbor.json
tests/topotests/ospf_gr_topo1/rt6/show_ip_ospf_neighbor.json
tests/topotests/ospf_gr_topo1/rt7/show_ip_ospf_neighbor.json
tests/topotests/ospf_topo1/test_ospf_topo1.py
tests/topotests/pim_acl/r1/ospf_neighbor.json
tests/topotests/pim_igmp_vrf/r1/ospf_blue_neighbor.json
tests/topotests/pim_igmp_vrf/r1/ospf_red_neighbor.json