]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
isdn: icn: Fix potentially wrong string handling
authorStefan Weil <weil@mail.berlios.de>
Sun, 30 Jan 2011 10:31:26 +0000 (10:31 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Feb 2011 22:17:51 +0000 (14:17 -0800)
commita29ae23f687649c35b1520a8f986497637a0cc62
tree23590d84873e98c1eef7ca50e5d78bd3ad4b2f6e
parentd9c8f498c3b41e686d3306dcf01d95941fcc6b48
isdn: icn: Fix potentially wrong string handling

This warning was reported by cppcheck:
drivers/isdn/icn/icn.c:1641: error: Dangerous usage of 'rev' (strncpy doesn't always 0-terminate it)

If strncpy copied 20 bytes, the destination string rev was not terminated.
The patch adds one more byte to rev and makes sure that this byte is
always 0.

Cc: Karsten Keil <isdn@linux-pingi.de>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Tejun Heo <tj@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/icn/icn.c