]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
Input: elan_i2c - fix regulator enable count imbalance after suspend/resume
authorHans de Goede <hdegoede@redhat.com>
Tue, 1 Mar 2022 07:39:50 +0000 (23:39 -0800)
committerPaolo Pisati <paolo.pisati@canonical.com>
Wed, 9 Mar 2022 14:17:58 +0000 (15:17 +0100)
commita2e9aba0f40b64c94f2ac9af11bfce5a787908fd
treef8a243220f0bad2684a2753934f9c1c24a99c703
parent9db6f79f8740165c032208e3b8cd1136afb81815
Input: elan_i2c - fix regulator enable count imbalance after suspend/resume

BugLink: https://bugs.launchpad.net/bugs/1964361
commit 04b7762e37c95d9b965d16bb0e18dbd1fa2e2861 upstream.

Before these changes elan_suspend() would only disable the regulator
when device_may_wakeup() returns false; whereas elan_resume() would
unconditionally enable it, leading to an enable count imbalance when
device_may_wakeup() returns true.

This triggers the "WARN_ON(regulator->enable_count)" in regulator_put()
when the elan_i2c driver gets unbound, this happens e.g. with the
hot-plugable dock with Elan I2C touchpad for the Asus TF103C 2-in-1.

Fix this by making the regulator_enable() call also be conditional
on device_may_wakeup() returning false.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220131135436.29638-2-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/input/mouse/elan_i2c_core.c