]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
can: remove obsolete assignment for CAN protocol error type
authorOliver Hartkopp <socketcan@hartkopp.net>
Sat, 21 Nov 2015 17:41:21 +0000 (18:41 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 23 Nov 2015 08:37:38 +0000 (09:37 +0100)
commita2ec19f888f1fb06e2424486423a16f86ad1fcc4
treec1644eda37c31376d5ed54b453d2d605cc357c46
parentffd461f80d536336811d573f197f3e6d9872d054
can: remove obsolete assignment for CAN protocol error type

The assignment 'cf->data[2] |= CAN_ERR_PROT_UNSPEC' used at CAN error message
creation time is obsolete as CAN_ERR_PROT_UNSPEC is zero and cf->data[2] is
initialized with zero in alloc_can_err_skb() anyway.

So we could either assign 'cf->data[2] = CAN_ERR_PROT_UNSPEC' correctly or we
can remove the obsolete OR operation entirely.

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
12 files changed:
drivers/net/can/bfin_can.c
drivers/net/can/c_can/c_can.c
drivers/net/can/janz-ican3.c
drivers/net/can/m_can/m_can.c
drivers/net/can/rcar_can.c
drivers/net/can/sja1000/sja1000.c
drivers/net/can/sun4i_can.c
drivers/net/can/ti_hecc.c
drivers/net/can/usb/ems_usb.c
drivers/net/can/usb/esd_usb2.c
drivers/net/can/usb/usb_8dev.c
drivers/net/can/xilinx_can.c