]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
spi: stm32: fix error check on mbr being -ve
authorColin Ian King <colin.king@canonical.com>
Thu, 22 Jun 2017 16:34:49 +0000 (17:34 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 23 Jun 2017 11:26:38 +0000 (12:26 +0100)
commita2f07d38d6981ed220d86b7df07e4ac6a1734443
tree2018ad9bac2d4fccb138c3547ee98dbaf2cec65c
parentdcbe0d84dfa5a3e72b8e6ce622cd5ac78abbcab8
spi: stm32: fix error check on mbr being -ve

The error check of mbr < 0 is always false because mbr is a u32. Make
mbt an int so that a -ve error return from stm32_spi_prepare_mbr can be
detected.

Detected by CoverityScan, CID#1446586 ("Unsigned compared against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-stm32.c