]> git.proxmox.com Git - mirror_qemu.git/commit
machine: do not crash if default RAM backend name has been stolen
authorIgor Mammedov <imammedo@redhat.com>
Mon, 22 May 2023 13:17:17 +0000 (15:17 +0200)
committerThomas Huth <thuth@redhat.com>
Fri, 26 May 2023 07:37:04 +0000 (09:37 +0200)
commita37531f2381c4e294e48b1417089474128388b44
tree056ce576dde2adbf59af04bbde58e97f6c5d4ca0
parent031616cd75ea1cea40eb130f4f4e900aeb0b2be4
machine: do not crash if default RAM backend name has been stolen

QEMU aborts when default RAM backend should be used (i.e. no
explicit '-machine memory-backend=' specified) but user
has created an object which 'id' equals to default RAM backend
name used by board.

 $QEMU -machine pc \
       -object memory-backend-ram,id=pc.ram,size=4294967296

 Actual results:
 QEMU 7.2.0 monitor - type 'help' for more information
 (qemu) Unexpected error in object_property_try_add() at ../qom/object.c:1239:
 qemu-kvm: attempt to add duplicate property 'pc.ram' to object (type 'container')
 Aborted (core dumped)

Instead of abort, check for the conflicting 'id' and exit with
an error, suggesting how to remedy the issue.

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2207886
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20230522131717.3780533-1-imammedo@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Shaoqin Huang <shahuang@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
hw/core/machine.c