]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
net: force dst_default_metrics to const section
authorEric Dumazet <edumazet@google.com>
Tue, 7 Aug 2012 10:55:45 +0000 (10:55 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 Aug 2012 23:00:28 +0000 (16:00 -0700)
commita37e6e344910a43b9ebc2bbf29a029f5ea942598
tree028fe1af3e85510fa7c341bfe3dadd099189156b
parent0c03eca3d995e73d691edea8c787e25929ec156d
net: force dst_default_metrics to const section

While investigating on network performance problems, I found this little
gem :

$ nm -v vmlinux | grep -1 dst_default_metrics
ffffffff82736540 b busy.46605
ffffffff82736560 B dst_default_metrics
ffffffff82736598 b dst_busy_list

Apparently, declaring a const array without initializer put it in
(writeable) bss section, in middle of possibly often dirtied cache
lines.

Since we really want dst_default_metrics be const to avoid any possible
false sharing and catch any buggy writes, I force a null initializer.

ffffffff818a4c20 R dst_default_metrics

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/dst.h
net/core/dst.c