]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
mtd: rawnand: fsmc: Fix use of SM ORDER
authorMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 28 Sep 2021 22:15:00 +0000 (00:15 +0200)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 4 Jan 2022 08:48:40 +0000 (09:48 +0100)
commita495528750cb6926b598c0894862dab0beb4c3cb
tree4f76df9fcf1919fd6c0daac495b7243582665314
parentc1a4ab830982653cf4c95db0280f84697f38a142
mtd: rawnand: fsmc: Fix use of SM ORDER

BugLink: https://bugs.launchpad.net/bugs/1951822
commit 9be1446ece291a1f08164bd056bed3d698681f8b upstream.

The introduction of the generic ECC engine API lead to a number of
changes in various drivers which broke some of them. Here is a typical
example: I expected the SM_ORDER option to be handled by the Hamming ECC
engine internals. Problem: the fsmc driver does not instantiate (yet) a
real ECC engine object so we had to use a 'bare' ECC helper instead of
the shiny rawnand functions. However, when not intializing this engine
properly and using the bare helpers, we do not get the SM ORDER feature
handled automatically. It looks like this was lost in the process so
let's ensure we use the right SM ORDER now.

Fixes: ad9ffdce4539 ("mtd: rawnand: fsmc: Fix external use of SW Hamming ECC helper")
Cc: stable@vger.kernel.org
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210928221507.199198-2-miquel.raynal@bootlin.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/mtd/nand/raw/fsmc_nand.c