]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
tracing/kprobes: Check whether get_kretprobe() returns NULL in kretprobe_dispatcher()
authorMasami Hiramatsu (Google) <mhiramat@kernel.org>
Fri, 27 May 2022 15:55:39 +0000 (00:55 +0900)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 26 Aug 2022 08:53:44 +0000 (10:53 +0200)
commita4b7aa7d76754a770edcc4173bd58f27024e3d5b
tree13fd6e6bd0a7a867211cacbeb0a382a8d1755404
parent91af2ddfeded90353d21327665affde9374d19af
tracing/kprobes: Check whether get_kretprobe() returns NULL in kretprobe_dispatcher()

BugLink: https://bugs.launchpad.net/bugs/1986718
commit cc72b72073ac982a954d3b43519ca1c28f03c27c upstream.

There is a small chance that get_kretprobe(ri) returns NULL in
kretprobe_dispatcher() when another CPU unregisters the kretprobe
right after __kretprobe_trampoline_handler().

To avoid this issue, kretprobe_dispatcher() checks the get_kretprobe()
return value again. And if it is NULL, it returns soon because that
kretprobe is under unregistering process.

This issue has been introduced when the kretprobe is decoupled
from the struct kretprobe_instance by commit d741bf41d7c7
("kprobes: Remove kretprobe hash"). Before that commit, the
struct kretprob_instance::rp directly points the kretprobe
and it is never be NULL.

Link: https://lkml.kernel.org/r/165366693881.797669.16926184644089588731.stgit@devnote2
Reported-by: Yonghong Song <yhs@fb.com>
Fixes: d741bf41d7c7 ("kprobes: Remove kretprobe hash")
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: bpf <bpf@vger.kernel.org>
Cc: Kernel Team <kernel-team@fb.com>
Cc: stable@vger.kernel.org
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
kernel/trace/trace_kprobe.c