]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
route: also update fnhe_genid when updating a route cache
authorXin Long <lucien.xin@gmail.com>
Fri, 17 Nov 2017 06:27:18 +0000 (14:27 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Tue, 13 Mar 2018 10:27:33 +0000 (11:27 +0100)
commita4c3549d985a8af23cdff1ed1a6427ebf153235c
treee36bcdc1f12c2e3539f01e5859bb8c85e5930525
parent32a1a4b917908da95117cfdf97db6cb8523715b0
route: also update fnhe_genid when updating a route cache

BugLink: http://bugs.launchpad.net/bugs/1745047
[ Upstream commit cebe84c6190d741045a322f5343f717139993c08 ]

Now when ip route flush cache and it turn out all fnhe_genid != genid.
If a redirect/pmtu icmp packet comes and the old fnhe is found and all
it's members but fnhe_genid will be updated.

Then next time when it looks up route and tries to rebind this fnhe to
the new dst, the fnhe will be flushed due to fnhe_genid != genid. It
causes this redirect/pmtu icmp packet acutally not to be applied.

This patch is to also reset fnhe_genid when updating a route cache.

Fixes: 5aad1de5ea2c ("ipv4: use separate genid for next hop exceptions")
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/ipv4/route.c