]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
x86: drop bogus "cc" clobber from __try_cmpxchg_user_asm()
authorJan Beulich <jbeulich@suse.com>
Tue, 7 Jun 2022 15:00:53 +0000 (17:00 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 16 Sep 2022 08:53:36 +0000 (10:53 +0200)
commita4cc45e5ab6cfc72d25237c79120eb0bb680c366
tree9e82a90816bca71585a6723f632ed4095a23cae4
parent8883cd29a378d4b7fde0a9bdef4c052e21782c0e
x86: drop bogus "cc" clobber from __try_cmpxchg_user_asm()

BugLink: https://bugs.launchpad.net/bugs/1988479
commit 1df931d95f4dc1c11db1123e85d4e08156e46ef9 upstream.

As noted (and fixed) a couple of times in the past, "=@cc<cond>" outputs
and clobbering of "cc" don't work well together. The compiler appears to
mean to reject such, but doesn't - in its upstream form - quite manage
to yet for "cc". Furthermore two similar macros don't clobber "cc", and
clobbering "cc" is pointless in asm()-s for x86 anyway - the compiler
always assumes status flags to be clobbered there.

Fixes: 989b5db215a2 ("x86/uaccess: Implement macros for CMPXCHG on user addresses")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Message-Id: <485c0c0b-a3a7-0b7c-5264-7d00c01de032@suse.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
arch/x86/include/asm/uaccess.h