]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
net: Move the permission check in sock_diag_put_filterinfo to packet_diag_dump
authorEric W. Biederman <ebiederm@xmission.com>
Wed, 23 Apr 2014 21:26:25 +0000 (14:26 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 24 Apr 2014 17:44:53 +0000 (13:44 -0400)
commita53b72c83a4216f2eb883ed45a0cbce014b8e62d
treee5a7f73a70a53c3485f3147de60f7c77b1ab7f4f
parent5187cd055b6e81fc6526109456f8b20623148d5f
net: Move the permission check in sock_diag_put_filterinfo to packet_diag_dump

The permission check in sock_diag_put_filterinfo is wrong, and it is so removed
from it's sources it is not clear why it is wrong.  Move the computation
into packet_diag_dump and pass a bool of the result into sock_diag_filterinfo.

This does not yet correct the capability check but instead simply moves it to make
it clear what is going on.

Reported-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/sock_diag.h
net/core/sock_diag.c
net/packet/diag.c