]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
dma-buf: Fix SET_NAME ioctl uapi
authorDaniel Vetter <daniel.vetter@intel.com>
Tue, 7 Apr 2020 13:30:02 +0000 (15:30 +0200)
committerSumit Semwal <sumit.semwal@linaro.org>
Mon, 27 Apr 2020 10:59:41 +0000 (16:29 +0530)
commita5bff92eaac45bdf6221badf9505c26792fdf99e
treea12728f7c2d44acebd9711ee52ea8c89c3e72cf0
parent6292b8efe32e6be408af364132f09572aed14382
dma-buf: Fix SET_NAME ioctl uapi

The uapi is the same on 32 and 64 bit, but the number isn't. Everyone
who botched this please re-read:

https://www.kernel.org/doc/html/v5.4-preprc-cpu/ioctl/botching-up-ioctls.html

Also, the type argument for the ioctl macros is for the type the void
__user *arg pointer points at, which in this case would be the
variable-sized char[] of a 0 terminated string. So this was botched in
more than just the usual ways.

Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Chenbo Feng <fengc@google.com>
Cc: Greg Hackmann <ghackmann@google.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Cc: minchan@kernel.org
Cc: surenb@google.com
Cc: jenhaochen@google.com
Cc: Martin Liu <liumartin@google.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Tested-by: Martin Liu <liumartin@google.com>
Reviewed-by: Martin Liu <liumartin@google.com>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
  [sumits: updated some checkpatch fixes, corrected author email]
Link: https://patchwork.freedesktop.org/patch/msgid/20200407133002.3486387-1-daniel.vetter@ffwll.ch
drivers/dma-buf/dma-buf.c
include/uapi/linux/dma-buf.h