]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ASoC: simple-card-utils: Do not handle device clock
authorSameer Pujar <spujar@nvidia.com>
Mon, 15 Mar 2021 17:31:31 +0000 (23:01 +0530)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 23 Apr 2021 09:50:59 +0000 (11:50 +0200)
commita5c71124cc4aa3e0e324dc2cf10badfb9e58a07f
tree91bfedb0fb08dee7bf54c250937d76d2e1ef701b
parent857976ca64374ebaf15c86eef5326db64bb17389
ASoC: simple-card-utils: Do not handle device clock

BugLink: https://bugs.launchpad.net/bugs/1923214
commit 8ca88d53351cc58d535b2bfc7386835378fb0db2 upstream.

This reverts commit 1e30f642cf29 ("ASoC: simple-card-utils: Fix device
module clock"). The original patch ended up breaking following platform,
which depends on set_sysclk() to configure internal PLL on wm8904 codec
and expects simple-card-utils to not update the MCLK rate.
 - "arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts"

It would be best if codec takes care of setting MCLK clock via DAI
set_sysclk() callback.

Reported-by: Michael Walle <michael@walle.cc>
Suggested-by: Mark Brown <broonie@kernel.org>
Suggested-by: Michael Walle <michael@walle.cc>
Fixes: 1e30f642cf29 ("ASoC: simple-card-utils: Fix device module clock")
Signed-off-by: Sameer Pujar <spujar@nvidia.com>
Tested-by: Michael Walle <michael@walle.cc>
Link: https://lore.kernel.org/r/1615829492-8972-2-git-send-email-spujar@nvidia.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/soc/generic/simple-card-utils.c