]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
MIPS: Clear ISA bit correctly in get_frame_info()
authorPaul Burton <paul.burton@imgtec.com>
Mon, 7 Nov 2016 15:07:02 +0000 (15:07 +0000)
committerTim Gardner <tim.gardner@canonical.com>
Mon, 13 Mar 2017 21:20:54 +0000 (15:20 -0600)
commita5c80086bc00f2535becbc001b440cab1836031d
tree550771f2ba0c66f5bd590e6d73ee17ef6757a9ba
parent42e56bbf95660cc8cfe7c94a019b3373b8c58390
MIPS: Clear ISA bit correctly in get_frame_info()

BugLink: http://bugs.launchpad.net/bugs/1672544
commit ccaf7caf2c73c6db920772bf08bf1d47b2170634 upstream.

get_frame_info() can be called in microMIPS kernels with the ISA bit
already clear. For example this happens when unwind_stack_by_address()
is called because we begin with a PC that has the ISA bit set & subtract
the (odd) offset from the preceding symbol (which does not have the ISA
bit set). Since get_frame_info() unconditionally subtracts 1 from the PC
in microMIPS kernels it incorrectly misaligns the address it then
attempts to access code at, leading to an address error exception.

Fix this by using msk_isa16_mode() to clear the ISA bit, which allows
get_frame_info() to function regardless of whether it is provided with a
PC that has the ISA bit set or not.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Fixes: 34c2f668d0f6 ("MIPS: microMIPS: Add unaligned access support.")
Cc: Leonid Yegoshin <leonid.yegoshin@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/14528/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
arch/mips/kernel/process.c