]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
selftests/bpf: Omit nodad flag when adding addresses to loopback
authorJakub Sitnicki <jakub@cloudflare.com>
Thu, 30 Jul 2020 12:53:25 +0000 (14:53 +0200)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 30 Jul 2020 22:52:13 +0000 (00:52 +0200)
commita6599abdeac30063baf89df166068b20758e0e86
tree54606362317ca9f5c0afcd2d5600e18796e9336c
parent80546ac4586c0bd326aa7ce80f076646db02bcd0
selftests/bpf: Omit nodad flag when adding addresses to loopback

Setting IFA_F_NODAD flag for IPv6 addresses to add to loopback is
unnecessary. Duplicate Address Detection does not happen on loopback
device.

Also, passing 'nodad' flag to 'ip address' breaks libbpf CI, which runs in
an environment with BusyBox implementation of 'ip' command, that doesn't
understand this flag.

Fixes: 0ab5539f8584 ("selftests/bpf: Tests for BPF_SK_LOOKUP attach point")
Reported-by: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Tested-by: Andrii Nakryiko <andrii@fb.com>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/20200730125325.1869363-1-jakub@cloudflare.com
tools/testing/selftests/bpf/prog_tests/sk_lookup.c