]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
p54: Initialize extra_len in p54_tx_80211
authorJason Conti <jason.conti@gmail.com>
Thu, 7 Apr 2011 19:09:57 +0000 (21:09 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 8 Apr 2011 17:06:30 +0000 (13:06 -0400)
commita6756da9eace8b4af73e9dea43f1fc2889224c94
tree7f1ac79ad2de9f422119f45d723af9bf3eb7bd66
parent96f372c95d32f76fa2b0e035e0a6269234bfda09
p54: Initialize extra_len in p54_tx_80211

This patch fixes a very serious off-by-one bug in
the driver, which could leave the device in an
unresponsive state.

The problem was that the extra_len variable [used to
reserve extra scratch buffer space for the firmware]
was left uninitialized. Because p54_assign_address
later needs the value to reserve additional space,
the resulting frame could be to big for the small
device's memory window and everything would
immediately come to a grinding halt.

Reference: https://bugs.launchpad.net/bugs/722185

Cc: <stable@kernel.org>
Acked-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: Jason Conti <jason.conti@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/p54/txrx.c