]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
udmabuf: validate ubuf->pagecount
authorPavel Skripkin <paskripkin@gmail.com>
Thu, 30 Dec 2021 14:26:49 +0000 (17:26 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 13:18:50 +0000 (15:18 +0200)
commita67b2913e291efbbfbfb86a614667628572584f9
treeff103880618cfdccc0735c97503b1c57880373f8
parentd4c4150b7d880d4e507def6f82e333a35c94ceb0
udmabuf: validate ubuf->pagecount

BugLink: https://bugs.launchpad.net/bugs/1971497
[ Upstream commit 2b6dd600dd72573c23ea180b5b0b2f1813405882 ]

Syzbot has reported GPF in sg_alloc_append_table_from_pages(). The
problem was in ubuf->pages == ZERO_PTR.

ubuf->pagecount is calculated from arguments passed from user-space. If
user creates udmabuf with list.size == 0 then ubuf->pagecount will be
also equal to zero; it causes kmalloc_array() to return ZERO_PTR.

Fix it by validating ubuf->pagecount before passing it to
kmalloc_array().

Fixes: fbb0de795078 ("Add udmabuf misc device")
Reported-and-tested-by: syzbot+2c56b725ec547fa9cb29@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20211230142649.23022-1-paskripkin@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/dma-buf/udmabuf.c