]> git.proxmox.com Git - qemu.git/commit
pci: call object_unparent() before free_qdev()
authorAmos Kong <kongjianjun@gmail.com>
Sun, 20 May 2012 09:57:45 +0000 (17:57 +0800)
committerAnthony Liguori <aliguori@us.ibm.com>
Wed, 30 May 2012 01:19:24 +0000 (20:19 -0500)
commita6de8ed80e1cf47d0f372e0856e6eeb6de9bbf0e
tree7cc00113c7e10ca1081dc5d14d79c004fa0451ec
parent9c3a596a03cc10c2d9097f057b9ccb9d557a4d5f
pci: call object_unparent() before free_qdev()

Start VM with 8 multiple-function block devs, hot-removing
those block devs by 'device_del ...' would cause qemu abort.

| (qemu) device_del virti0-0-0
| (qemu) **
|ERROR:qom/object.c:389:object_delete: assertion failed: (obj->ref == 0)

It's a regression introduced by commit 57c9fafe

The whole PCI slot should be removed once. Currently only one func
is cleaned in pci_unplug_device(), if you try to remove a single
func by monitor cmd.

free_qdev() are called for all functions in slot,
but unparent_delete() is only called for one
function.

Signed-off-by: XXXX
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/acpi_piix4.c
hw/pci.c