]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
crypto: x86/crct10dif-pcl - fix use via crypto_shash_digest()
authorEric Biggers <ebiggers@google.com>
Sun, 31 Mar 2019 20:04:13 +0000 (13:04 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 30 Jul 2019 10:58:17 +0000 (12:58 +0200)
commita6e0fb31efab60f519e97c6d6753236dc50e3f92
tree1691ddcac6de9f01c72ef6119383b4d4d588623f
parent58ee7ac1653da91ece49d9682cbeb824d2245253
crypto: x86/crct10dif-pcl - fix use via crypto_shash_digest()

BugLink: https://bugs.launchpad.net/bugs/1836614
commit dec3d0b1071a0f3194e66a83d26ecf4aa8c5910e upstream.

The ->digest() method of crct10dif-pclmul reads the current CRC value
from the shash_desc context.  But this value is uninitialized, causing
crypto_shash_digest() to compute the wrong result.  Fix it.

Probably this wasn't noticed before because lib/crc-t10dif.c only uses
crypto_shash_update(), not crypto_shash_digest().  Likewise,
crypto_shash_digest() is not yet tested by the crypto self-tests because
those only test the ahash API which only uses shash init/update/final.

Fixes: 0b95a7f85718 ("crypto: crct10dif - Glue code to cast accelerated CRCT10DIF assembly as a crypto transform")
Cc: <stable@vger.kernel.org> # v3.11+
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
arch/x86/crypto/crct10dif-pclmul_glue.c