]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
UBIFS: use an IS_ERR test rather than a NULL test
authorJulien Brunel <brunel@diku.dk>
Fri, 29 Aug 2008 09:08:32 +0000 (11:08 +0200)
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Tue, 30 Sep 2008 08:12:56 +0000 (11:12 +0300)
commita70948b564e9f6cb81115c606d46f5b74a77b7c2
treee1a75ccf9580746d22409430b346436fd148dab7
parent746103aca2ae2b044e32a6ab06a6536652124c99
UBIFS: use an IS_ERR test rather than a NULL test

In case of error, the function kthread_create returns an ERR pointer,
but never returns a NULL pointer. So a NULL test that comes before an
IS_ERR test should be deleted.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@match_bad_null_test@
expression x, E;
statement S1,S2;
@@
x = kthread_create(...)
... when != x = E
* if (x == NULL)
S1 else S2
// </smpl>

Signed-off-by: Julien Brunel <brunel@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
fs/ubifs/super.c