]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
net: bonding: fix tlb_dynamic_lb default value
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Tue, 12 Sep 2017 12:10:05 +0000 (15:10 +0300)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 19 Oct 2017 14:48:21 +0000 (09:48 -0500)
commita74a2dccf979793702ff993c26b9e660c88bdf61
tree014a7d7612bb4e994038a393667cba791b02b301
parent7fa3f1ebfcb1802df66a42cccebe2f26dfde58c6
net: bonding: fix tlb_dynamic_lb default value

BugLink: http://bugs.launchpad.net/bugs/1723145
[ Upstream commit f13ad104b4e886a03e75f130daf579ef9bf33dfc ]

Commit 8b426dc54cf4 ("bonding: remove hardcoded value") changed the
default value for tlb_dynamic_lb which lead to either broken ALB mode
(since tlb_dynamic_lb can be changed only in TLB) or setting TLB mode
with tlb_dynamic_lb equal to 0.
The first issue was recently fixed by setting tlb_dynamic_lb to 1 always
when switching to ALB mode, but the default value is still wrong and
we'll enter TLB mode with tlb_dynamic_lb equal to 0 if the mode is
changed via netlink or sysfs. In order to restore the previous behaviour
and default value simply remove the mode check around the default param
initialization for tlb_dynamic_lb which will always set it to 1 as
before.

Fixes: 8b426dc54cf4 ("bonding: remove hardcoded value")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Acked-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/net/bonding/bond_main.c