]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
kernfs: Fix range checks in kernfs_get_target_path
authorBernd Edlinger <bernd.edlinger@hotmail.de>
Sat, 7 Jul 2018 17:52:47 +0000 (17:52 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Sep 2018 20:38:57 +0000 (22:38 +0200)
commita75e78f21f9ad4b810868c89dbbabcc3931591ca
tree5f2d9f66299b62c9fea792a499a152f205ff26a3
parentbdae566d5d9733b6e32b378668b84eadf28a94d4
kernfs: Fix range checks in kernfs_get_target_path

The terminating NUL byte is only there because the buffer is
allocated with kzalloc(PAGE_SIZE, GFP_KERNEL), but since the
range-check is off-by-one, and PAGE_SIZE==PATH_MAX, the
returned string may not be zero-terminated if it is exactly
PATH_MAX characters long.  Furthermore also the initial loop
may theoretically exceed PATH_MAX and cause a fault.

Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/kernfs/symlink.c