]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
locking/lockdep: Fix overflow in presentation of average lock-time
authorChris Wilson <chris@chris-wilson.co.uk>
Sat, 25 Jul 2020 18:51:10 +0000 (19:51 +0100)
committerIngo Molnar <mingo@kernel.org>
Sat, 25 Jul 2020 19:47:42 +0000 (21:47 +0200)
commita7ef9b28aa8d72a1656fa6f0a01bbd1493886317
treedc43e39c24124df11dc97333de748b4c895ca91f
parent23ee3e4e5bd27bdbc0f1785eef7209ce872794c7
locking/lockdep: Fix overflow in presentation of average lock-time

Though the number of lock-acquisitions is tracked as unsigned long, this
is passed as the divisor to div_s64() which interprets it as a s32,
giving nonsense values with more than 2 billion acquisitons. E.g.

  acquisitions   holdtime-min   holdtime-max holdtime-total   holdtime-avg
  -------------------------------------------------------------------------
    2350439395           0.07         353.38   649647067.36          0.-32

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20200725185110.11588-1-chris@chris-wilson.co.uk
kernel/locking/lockdep_proc.c