]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
zram: off by one in read_block_state()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 5 Nov 2021 20:45:12 +0000 (13:45 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 6 Nov 2021 20:30:43 +0000 (13:30 -0700)
commita88e03cf3d190cf46bc4063a9b7efe87590de5f4
tree1ebbdecc2f00893fbcdfc066c0bedf04731265bc
parent4aabdc14c4d2a01c2968bdc8919f81d9f9b4f790
zram: off by one in read_block_state()

snprintf() returns the number of bytes it would have printed if there
were space.  But it does not count the NUL terminator.  So that means
that if "count == copied" then this has already overflowed by one
character.

This bug likely isn't super harmful in real life.

Link: https://lkml.kernel.org/r/20210916130404.GA25094@kili
Fixes: c0265342bff4 ("zram: introduce zram memory tracking")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/block/zram/zram_drv.c