]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
x86/srso: Fix srso_show_state() side effect
authorJosh Poimboeuf <jpoimboe@kernel.org>
Tue, 5 Sep 2023 05:04:45 +0000 (22:04 -0700)
committerBorislav Petkov (AMD) <bp@alien8.de>
Tue, 19 Sep 2023 08:53:34 +0000 (10:53 +0200)
commita8cf700c17d9ca6cb8ee7dc5c9330dbac3948237
tree64fc44764beadcd1f303536a84a5e3ec953e93e6
parent10f4c9b9a33b7df000f74fa0d896351fb1a61e6a
x86/srso: Fix srso_show_state() side effect

Reading the 'spec_rstack_overflow' sysfs file can trigger an unnecessary
MSR write, and possibly even a (handled) exception if the microcode
hasn't been updated.

Avoid all that by just checking X86_FEATURE_IBPB_BRTYPE instead, which
gets set by srso_select_mitigation() if the updated microcode exists.

Fixes: fb3bd914b3ec ("x86/srso: Add a Speculative RAS Overflow mitigation")
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>
Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/27d128899cb8aee9eb2b57ddc996742b0c1d776b.1693889988.git.jpoimboe@kernel.org
arch/x86/kernel/cpu/bugs.c