]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
nvme initialize core quirks before calling nvme_init_subsystem
authorPankaj Raghav <p.raghav@samsung.com>
Thu, 1 Dec 2022 12:52:34 +0000 (13:52 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 14 Dec 2022 13:02:56 +0000 (14:02 +0100)
commita8d7127ac7e0eeb9dd89e5d989d5f272ff0d9898
treee27f444d2f4e8e8f8e9d6beaf5b773946f34df21
parent74f763f4c3f3941802d228e0b16e2a8e5dae139f
nvme initialize core quirks before calling nvme_init_subsystem

[ Upstream commit 6f2d71524bcfdeb1fcbd22a4a92a5b7b161ab224 ]

A device might have a core quirk for NVME_QUIRK_IGNORE_DEV_SUBNQN
(such as Samsung X5) but it would still give a:

    "missing or invalid SUBNQN field"

warning as core quirks are filled after calling nvme_init_subnqn.  Fill
ctrl->quirks from struct core_quirks before calling nvme_init_subsystem
to fix this.

Tested on a Samsung X5.

Fixes: ab9e00cc72fa ("nvme: track subsystems")
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit b8c2f0392d1d666801fb1092735215bbe32ae6f5)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
drivers/nvme/host/core.c