]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ext4: don't mark mmp buffer head dirty
authorLi Dongyang <dongyangli@ddn.com>
Sat, 15 Sep 2018 21:11:25 +0000 (17:11 -0400)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:50:20 +0000 (19:50 -0600)
commita8dc55388b06f80ab27cea68d9c6b6b79f6a05dd
tree0129e952a75c8b454e0dcb1f54f50e1c91e8d7fa
parentac495f0c04de4d6f05ffd66dcd5f04c78fc8cbcf
ext4: don't mark mmp buffer head dirty

BugLink: https://bugs.launchpad.net/bugs/1836287
commit fe18d649891d813964d3aaeebad873f281627fbc upstream.

Marking mmp bh dirty before writing it will make writeback
pick up mmp block later and submit a write, we don't want the
duplicate write as kmmpd thread should have full control of
reading and writing the mmp block.
Another reason is we will also have random I/O error on
the writeback request when blk integrity is enabled, because
kmmpd could modify the content of the mmp block(e.g. setting
new seq and time) while the mmp block is under I/O requested
by writeback.

Signed-off-by: Li Dongyang <dongyangli@ddn.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/ext4/mmp.c