]> git.proxmox.com Git - mirror_qemu.git/commit
scsi-disk: Don't use empty string as device id
authorKevin Wolf <kwolf@redhat.com>
Fri, 25 Jan 2019 16:30:28 +0000 (17:30 +0100)
committerKevin Wolf <kwolf@redhat.com>
Fri, 1 Feb 2019 12:47:09 +0000 (13:47 +0100)
commita8f58afcdb86e266e06c9dc41a71605e570244c3
tree134ff16e7c26dedbdbb60d951eb8be111c8a39b2
parenta5df73baaf27a2aa4a911545ee1ee6286a5372e4
scsi-disk: Don't use empty string as device id

scsi-disk includes in the Device Identification VPD page, depending on
configuration amongst others, a vendor specific designator that consists
either of the serial number if given or the BlockBackend name (which is
a host detail that better shouldn't have been leaked to the guest, but
now we have to maintain it for compatibility).

With anonymous BlockBackends, i.e. scsi-disk devices constructed with
drive=<node-name>, and no serial number explicitly specified, this ends
up as an empty string. If this happens to more than one disk, we have
accidentally signalled to the OS that this is a multipath setup, which
is obviously not what was intended.

Instead of using an empty string for the vendor specific designator,
simply leave out that designator, which makes Linux detect such setups
as separate disks again.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
hw/scsi/scsi-disk.c