]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
sctp: check af before verify address in sctp_addr_id2transport
authorXin Long <lucien.xin@gmail.com>
Tue, 7 Feb 2017 12:56:08 +0000 (20:56 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 19 Jul 2017 07:59:08 +0000 (09:59 +0200)
commita92417d316f1f46efbe2a77276ef7c1b97878871
tree230ae6b33ab071997565427f3762a63599abca10
parentaa3d6657000ebafa36bfc36193701b170a1e61fd
sctp: check af before verify address in sctp_addr_id2transport

BugLink: http://bugs.launchpad.net/bugs/1702863
[ Upstream commit 912964eacb111551db73429719eb5fadcab0ff8a ]

Commit 6f29a1306131 ("sctp: sctp_addr_id2transport should verify the
addr before looking up assoc") invoked sctp_verify_addr to verify the
addr.

But it didn't check af variable beforehand, once users pass an address
with family = 0 through sockopt, sctp_get_af_specific will return NULL
and NULL pointer dereference will be caused by af->sockaddr_len.

This patch is to fix it by returning NULL if af variable is NULL.

Fixes: 6f29a1306131 ("sctp: sctp_addr_id2transport should verify the addr before looking up assoc")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
net/sctp/socket.c