]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
gpiolib: rewrite gpiodev_add_to_list
authorBamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Fri, 26 Feb 2016 14:37:14 +0000 (22:37 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 7 Mar 2016 05:02:46 +0000 (12:02 +0700)
commita961f9b472de93e770d53b7340a58dbff64b4075
treeb5f1523191402b63e554b41c472a642d03147bfe
parent24030d9d9550d1a0b9bfcf6b60da29f7a2bb31cf
gpiolib: rewrite gpiodev_add_to_list

The original code of gpiodev_add_to_list is not very clear which
lead to bugs or compiling warning, reference the following patches:
Bugs:
1.  Commit ef7c7553039b ("gpiolib: improve overlap check of range of
    gpio").
2.  Commit 96098df125c0 ("gpiolib: fix chip order in gpio list")

Warning:
1.  Commit e28ecca6eac4 ("gpio: fix warning about iterator").
of gpio").

There is a off-list discussion about how to improve it consequently.
This commit try to follow this by rewriting the whole functions.

Tested pass with my gpio mockup driver and test scripts[1].

[1] http://www.spinics.net/lists/linux-gpio/msg09598.html

Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib.c