]> git.proxmox.com Git - mirror_qemu.git/commit
qga-win: Fixing msi upgrade disallow in WiX file
authorBishara AbuHattoum <bishara@daynix.com>
Thu, 28 Jun 2018 14:58:16 +0000 (17:58 +0300)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 3 Jul 2018 20:20:50 +0000 (15:20 -0500)
commita972304d187b104ebec327bc824b23a5a3589ac3
tree101240db7e5c1c613bdc4d68a5abba61664ecd30
parent84ece8ef6c70ea1852ec47805531017b75d46d68
qga-win: Fixing msi upgrade disallow in WiX file

Issue: When upgrading qemu-ga using the msi from an old version
       to a newer one, the upgrade is not allowed by the msi
       showing this error message "Another version of this product
       is already installed."

BZ# 1536331: https://bugzilla.redhat.com/show_bug.cgi?id=1536331

Fix: For the upgrade to be allowed by the msi the WiX file must
     provide three things:
      1. Changing product's Id. (assigning it to "*")
      2. Constant product's UpgradeId. (exists)
      3. Changing version. (exists)

Reference: http://wixtoolset.org/documentation/manual/v3/howtos/updates/major_upgrade.html

Signed-off-by: Bishara AbuHattoum <bishara@daynix.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qga/installer/qemu-ga.wxs