]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
HID: magicmouse: Fix an error handling path in magicmouse_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 28 Dec 2021 21:09:17 +0000 (22:09 +0100)
committerPaolo Pisati <paolo.pisati@canonical.com>
Fri, 28 Jan 2022 10:03:07 +0000 (11:03 +0100)
commita97affd0a20968dc47c069fe6652f949ce809334
tree77d50938dac90f45fe507e9b6ef037adea3e3e90
parent306d80157c40fbf82b7ff8521b8e46b802976cad
HID: magicmouse: Fix an error handling path in magicmouse_probe()

BugLink: https://bugs.launchpad.net/bugs/1959376
commit 33812fc7c8d77a43b7e2bf36a0d5a57c277a4b0c upstream.

If the timer introduced by the commit below is started, then it must be
deleted in the error handling of the probe. Otherwise it would trigger
once the driver is no more.

Fixes: 0b91b4e4dae6 ("HID: magicmouse: Report battery level over USB")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Tested-by: José Expósito <jose.exposito89@gmail.com>
Reported-by: <syzbot+a437546ec71b04dfb5ac@syzkaller.appspotmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/hid/hid-magicmouse.c