]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
bnxt_en: Adjust logging of firmware messages in case of released token in __hwrm_send()
authorAleksandr Mishin <amishin@t-argos.ru>
Tue, 11 Jun 2024 08:25:46 +0000 (11:25 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 13 Jun 2024 15:05:46 +0000 (08:05 -0700)
commita9b9741854a9fe9df948af49ca5514e0ed0429df
tree94ee74d5bc0af17a1b7b0ad476d84d8a36894e89
parenta6736a0addd60fccc3a3508461d72314cc609772
bnxt_en: Adjust logging of firmware messages in case of released token in __hwrm_send()

In case of token is released due to token->state == BNXT_HWRM_DEFERRED,
released token (set to NULL) is used in log messages. This issue is
expected to be prevented by HWRM_ERR_CODE_PF_UNAVAILABLE error code. But
this error code is returned by recent firmware. So some firmware may not
return it. This may lead to NULL pointer dereference.
Adjust this issue by adding token pointer check.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 8fa4219dba8e ("bnxt_en: add dynamic debug support for HWRM messages")
Suggested-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/20240611082547.12178-1-amishin@t-argos.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c