]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
mailbox: mtk-cmdq: Validate alias_id on probe
authorFei Shao <fshao@chromium.org>
Thu, 14 Oct 2021 12:03:51 +0000 (20:03 +0800)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 7 Dec 2021 06:33:02 +0000 (07:33 +0100)
commita9fe9645868e2b7dff980c4d6f58b40448a97318
tree5b9ebcc7d4f787b2b5a8bcf1d56b11fb1c57debc
parent9e5c3963f4036e6a5afc175e4a818ea7aa64c916
mailbox: mtk-cmdq: Validate alias_id on probe

BugLink: https://bugs.launchpad.net/bugs/1951822
[ Upstream commit 5c154b6a51c2d2d7f266b3ef49b7dd1dc8cb5b65 ]

of_alias_get_id() may return -ENODEV which leads to illegal access to
the cmdq->clocks array.
Adding a check over alias_id to prevent the unexpected behavior.

Fixes: 85dfdbfc13ea ("mailbox: cmdq: add multi-gce clocks support for mt8195")
Signed-off-by: Fei Shao <fshao@chromium.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/mailbox/mtk-cmdq-mailbox.c