]> git.proxmox.com Git - mirror_qemu.git/commit
filter-mirror: segfault when specifying non existent device
authorEduardo Otubo <otubo@redhat.com>
Fri, 29 Sep 2017 12:03:39 +0000 (14:03 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Mon, 16 Oct 2017 20:16:06 +0000 (23:16 +0300)
commitaa1530dec499f7525d2ccaa0e3a876dc8089ed1e
tree180587d64b62f4f918cc7f43616498949e05323d
parent534fd8142fae81b621ff61524f319163d2bb1f7b
filter-mirror: segfault when specifying non existent device

When using filter-mirror like the example below where the interface
'ndev0' does not exist on the host, QEMU crashes into segmentation
fault.

 $ qemu-system-x86_64 -S -machine pc -netdev user,id=ndev0 -object filter-mirror,id=test-object,netdev=ndev0

This happens because the function filter_mirror_setup() does not check
if the device actually exists and still keep on processing calling
qemu_chr_find(). This patch fixes this issue.

Signed-off-by: Eduardo Otubo <otubo@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
net/filter-mirror.c