]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
i40e/i40evf: Revert "i40e/i40evf: bump tail only in multiples of 8"
authorAlexander Duyck <alexander.h.duyck@intel.com>
Sun, 22 Oct 2017 00:51:50 +0000 (17:51 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 31 Oct 2017 17:41:10 +0000 (10:41 -0700)
commitaa250f1186319f1e0b9b4a1d99022fe32251b8b6
tree31611b8514bb648856b6fb49df882051963b55cb
parent3e6b1cf7613393a7c8648133daf0e853c4e05220
i40e/i40evf: Revert "i40e/i40evf: bump tail only in multiples of 8"

This reverts commit 11f29003d6376fb123b7c3779dba49bb56fb0815.

I am reverting this as I am fairly certain this can result in a memory leak
when combined with the current page recycling scheme. Specifically we end
up attempting to allocate fewer buffers than we recycled and this results
in us rewinding the next to alloc pointer which leads to leaks when we
overwrite the rx_buffer_info when processing the next frame.

Fixes: 11f29003d637 ("i40e/i40evf: bump tail only in multiples of 8")
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_txrx.c
drivers/net/ethernet/intel/i40evf/i40e_txrx.c